On Tue, Sep 1, 2020 at 3:10 PM Kim Phillips <kim.phill...@amd.com> wrote:
>
> The ITLB Instruction Fetch Hits event isn't documented even in
> later zen1 PPRs, but it seems to count correctly on zen1 hardware.
>
> Add it to zen1 group so zen1 users can use the upcoming IC Fetch Miss
> Ratio Metric.
>
> The IF1G, 1IF2M, IF4K (Instruction fetches to a 1 GB, 2 MB, and 4K page)
> unit masks are not added because unlike zen2 hardware, zen1 hardware
> counts all its unit masks with a 0 unit mask according to the old
> convention:
>
> zen1$ perf stat -e cpu/event=0x94/,cpu/event=0x94,umask=0xff/ sleep 1
>
> Performance counter stats for 'sleep 1':
>
> 211,318 cpu/event=0x94/u
> 211,318 cpu/event=0x94,umask=0xff/u
>
> Rome/zen2:
>
> zen2$ perf stat -e cpu/event=0x94/,cpu/event=0x94,umask=0xff/ sleep 1
>
> Performance counter stats for 'sleep 1':
>
> 0 cpu/event=0x94/u
> 190,744 cpu/event=0x94,umask=0xff/u
>
> Signed-off-by: Kim Phillips <kim.phill...@amd.com>
Acked-by: Ian Rogers <irog...@google.com>
Thanks,
Ian
> Cc: Peter Zijlstra <pet...@infradead.org>
> Cc: Ingo Molnar <mi...@redhat.com>
> Cc: Arnaldo Carvalho de Melo <a...@kernel.org>
> Cc: Mark Rutland <mark.rutl...@arm.com>
> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com>
> Cc: Jiri Olsa <jo...@redhat.com>
> Cc: Namhyung Kim <namhy...@kernel.org>
> Cc: Vijay Thakkar <vijaythak...@me.com>
> Cc: Andi Kleen <a...@linux.intel.com>
> Cc: John Garry <john.ga...@huawei.com>
> Cc: Kan Liang <kan.li...@linux.intel.com>
> Cc: Yunfeng Ye <yeyunf...@huawei.com>
> Cc: Jin Yao <yao....@linux.intel.com>
> Cc: "Martin Liška" <mli...@suse.cz>
> Cc: Borislav Petkov <b...@suse.de>
> Cc: Jon Grimm <jon.gr...@amd.com>
> Cc: Martin Jambor <mjam...@suse.cz>
> Cc: Michael Petlan <mpet...@redhat.com>
> Cc: William Cohen <wco...@redhat.com>
> Cc: Stephane Eranian <eran...@google.com>
> Cc: Ian Rogers <irog...@google.com>
> Cc: linux-perf-us...@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> tools/perf/pmu-events/arch/x86/amdzen1/branch.json | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tools/perf/pmu-events/arch/x86/amdzen1/branch.json
> b/tools/perf/pmu-events/arch/x86/amdzen1/branch.json
> index a9943eeb8d6b..4ceb67a0db21 100644
> --- a/tools/perf/pmu-events/arch/x86/amdzen1/branch.json
> +++ b/tools/perf/pmu-events/arch/x86/amdzen1/branch.json
> @@ -19,5 +19,10 @@
> "EventName": "bp_de_redirect",
> "EventCode": "0x91",
> "BriefDescription": "Decoder Overrides Existing Branch Prediction
> (speculative)."
> + },
> + {
> + "EventName": "bp_l1_tlb_fetch_hit",
> + "EventCode": "0x94",
> + "BriefDescription": "The number of instruction fetches that hit in the
> L1 ITLB."
> }
> ]
> --
> 2.27.0
>
