Hi Arnaldo and Ian, On Fri, Sep 4, 2020 at 3:41 AM Arnaldo Carvalho de Melo <a...@kernel.org> wrote: > > Em Thu, Sep 03, 2020 at 10:47:39AM -0700, Ian Rogers escreveu: > > On Thu, Sep 3, 2020 at 8:25 AM Namhyung Kim <namhy...@kernel.org> wrote: > > > The new string should have enough space for the original string and > > > the back slashes IMHO. > > > > Cc: John Garry <john.ga...@huawei.com> > > > Cc: Kajol Jain <kj...@linux.ibm.com> > > > Cc: Ian Rogers <irog...@google.com> > > > Signed-off-by: Namhyung Kim <namhy...@kernel.org> > > > > Reviewed-by: Ian Rogers <irog...@google.com> > > > > Definitely looks like the right fix. I'm surprised this hasn't shown > > up in sanitizer testing.
I guess the code didn't run on most arch (including x86) since they don't have backslashes. > > Yeap, good catch! Namyung you forgot to add the Fixes tag + Cc the patch > author that introduced that bug, I did it: > > Cc: William Cohen <wco...@redhat.com> > Fixes: fbc2844e84038ce3 ("perf vendor events: Use more flexible pattern > matching for CPU identification for mapfile.csv" > > Please consider doing it next time :-) Oh, right! Will do it later.. Thanks Namhyung