On 04/09/2020 17:21:15+0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszew...@baylibre.com> > > Align the arguments passed to devm_rtc_device_register() with the upper > line. > > Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> > --- > drivers/rtc/rtc-rx8010.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-rx8010.c b/drivers/rtc/rtc-rx8010.c > index 181fc21cefa8..ed8ba38b4991 100644 > --- a/drivers/rtc/rtc-rx8010.c > +++ b/drivers/rtc/rtc-rx8010.c > @@ -450,7 +450,7 @@ static int rx8010_probe(struct i2c_client *client, > } > > rx8010->rtc = devm_rtc_device_register(&client->dev, client->name, > - &rx8010_rtc_ops, THIS_MODULE); > + &rx8010_rtc_ops, THIS_MODULE); >
You have bonus points if you replace that patch by switching from devm_rtc_device_register to devm_rtc_allocate_device and rtc_register_device. More bonus points if you also set range_min and range_max and then get rid of the range checking in set_time. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
