Re: [PATCH v1 02/12] fpga: create intel max10 bmc security engine

[Russ Weight]

On 9/4/20 5:01 PM, Randy Dunlap wrote:

On 9/4/20 4:52 PM, Russ Weight wrote:

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index 97c0a6cc2ba7..0f0bed68e618 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -244,4 +244,15 @@ config IFPGA_SEC_MGR
          region and for the BMC. Select this option to enable
          updates for secure FPGA devices.

+config IFPGA_M10_BMC_SECURE

+        tristate "Intel MAX10 BMC security engine"
+       depends on MFD_INTEL_M10_BMC && IFPGA_SEC_MGR
+        help
+          Secure update support for the Intel MAX10 board management
+         controller.

Please consistently use one tab to indent Kconfig keywords (tristate, depends, 
help)
and one tab + 2 spaces to indent help text.
(as in Documentation/process/coding-style.rst)

Thanks for the feedback. I'll fix these.

+
+         This is a subdriver of the Intel MAX10 board management controller
+         (BMC) and provides support for secure updates for the BMC image,
+         the FPGA image, the Root Entry Hashes, etc.
+
  endif # FPGA

thanks.