On Sun, 11 Nov 2007 07:29:35 +0800 "dave chung" <[EMAIL PROTECTED]> wrote:
> On 11/10/07, Stanislav Brabec <[EMAIL PROTECTED]> wrote: > > Attached patch fixes two compilation problems of s1d13xxxfb.c: > > - Fixes outdated dbg() message to fix compilation error with debugging > > enabled. > > - Do not read kernel command line options when compiled as module. > > > > Signed-off-by: Stanislav Brabec <[EMAIL PROTECTED]> > > > > --- linux-2.6.23/drivers/video/s1d13xxxfb.c 2007-10-09 > > 22:31:38.000000000 +0200 > > +++ linux-2.6.23/drivers/video/s1d13xxxfb.c 2007-11-02 > > 16:48:34.000000000 +0100 > > @@ -540,7 +540,7 @@ > > int ret = 0; > > u8 revision; > > > > - dbg("probe called: device is %p\n", dev); > > + dbg("probe called: device is %p\n", pdev); > > > > printk(KERN_INFO "Epson S1D13XXX FB Driver\n"); > > > > @@ -753,8 +753,11 @@ > > static int __init > > s1d13xxxfb_init(void) > > { > > + > > +#ifndef MODULE > > if (fb_get_options("s1d13xxxfb", NULL)) > > return -ENODEV; > > +#endif > > > > return platform_driver_register(&s1d13xxxfb_driver); > > } > > > > > >________________________________________________________________________ > > Stanislav Brabec > > http://www.penguin.cz/~utx > > > > - > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to [EMAIL PROTECTED] > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > > > we also need to look at splitting out the "chip revision", which is > currently hard set, as I have had very good results with this driver > and chip S1D13506, which is functionally similar but without the > external clocking and without teh internal ram. > We also have some build dependancies related to "CONFIG_FB_S1D13XXX" > and ics1523 , this chip is not used on the full range of S1D13XXX and > causes errors in the build , for chips such as S1D13506. > potentially we could re-use most of the code, but would need a way to > pass in S1D_CHIP_REV and one or 2 other chip specific data items. Im all for that. Got 2 platforms (Mobilepro 900c & HP Jornada 720) with both uses S1D13... based chipsets. The driver should make more room for similiar versions. > > Steve > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/