Re: [PATCH net-next v3 4/6] net: dsa: mt7530: Add the support of MT7531 switch

[Jakub Kicinski]

On Fri, 4 Sep 2020 22:21:59 +0800 Landen Chao wrote:
> +static int
> +mt7531_cpu_port_config(struct dsa_switch *ds, int port)
> +{
> +     struct mt7530_priv *priv = ds->priv;
> +     phy_interface_t interface;
> +     int speed;
> +
> +     switch (port) {
> +     case 5:
> +             if (mt7531_is_rgmii_port(priv, port))
> +                     interface = PHY_INTERFACE_MODE_RGMII;
> +             else
> +                     interface = PHY_INTERFACE_MODE_2500BASEX;
> +
> +             priv->p5_interface = interface;
> +             break;
> +     case 6:
> +             interface = PHY_INTERFACE_MODE_2500BASEX;
> +
> +             mt7531_pad_setup(ds, interface);
> +
> +             priv->p6_interface = interface;
> +             break;
> +     };

stray semicolon