On Mon, Nov 12, 2007 at 04:44:56PM +0100, Jesper Nilsson wrote:
> On Fri, Nov 09, 2007 at 03:19:32PM -0800, Andrew Morton wrote:
> > > if (timeval_cmp(&t->tv_expires, &tv) <= 0)
> >
> > You have a private timeval_cmp(). Please take a look at utilising
> > include/linux/time.h:timeval_compare() instead. If that doesn't suit then
> > we'd entertain extensions of that interface. Adding private code to do
> > something as common as this is not a good thing.
Unfortunately, the above code lies to us.
The comparison is no longer on timeval, but on a fasttimer_t,
which contains different data. The name is just a leftover from when
it was a timeval.
I'll change the name of the function to highlight this.
Best regards,
/^JN - Jesper Nilsson
--
Jesper Nilsson -- [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
