On Tue, Sep 08, 2020 at 03:00:59PM -0500, Eddie James wrote:
> Mask the IRQ status to only the bits that the driver checks. This
> prevents excessive driver warnings when operating in slave mode
> when additional bits are set that the driver doesn't handle.
> 
> Signed-off-by: Eddie James <eaja...@linux.ibm.com>

Reviewed-by: Tao Ren <rentao.b...@gmail.com>

> ---
>  drivers/i2c/busses/i2c-aspeed.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
> index 31268074c422..2a388911038a 100644
> --- a/drivers/i2c/busses/i2c-aspeed.c
> +++ b/drivers/i2c/busses/i2c-aspeed.c
> @@ -69,6 +69,7 @@
>   * These share bit definitions, so use the same values for the enable &
>   * status bits.
>   */
> +#define ASPEED_I2CD_INTR_ALL                         0xf000ffff
>  #define ASPEED_I2CD_INTR_SDA_DL_TIMEOUT                      BIT(14)
>  #define ASPEED_I2CD_INTR_BUS_RECOVER_DONE            BIT(13)
>  #define ASPEED_I2CD_INTR_SLAVE_MATCH                 BIT(7)
> @@ -604,6 +605,7 @@ static irqreturn_t aspeed_i2c_bus_irq(int irq, void 
> *dev_id)
>       writel(irq_received & ~ASPEED_I2CD_INTR_RX_DONE,
>              bus->base + ASPEED_I2C_INTR_STS_REG);
>       readl(bus->base + ASPEED_I2C_INTR_STS_REG);
> +     irq_received &= ASPEED_I2CD_INTR_ALL;
>       irq_remaining = irq_received;
>  
>  #if IS_ENABLED(CONFIG_I2C_SLAVE)
> -- 
> 2.26.2
> 

Reply via email to