Hi Arnaldo, On Wed, Sep 9, 2020 at 9:27 PM Arnaldo Carvalho de Melo <a...@kernel.org> wrote: > > Em Wed, Sep 09, 2020 at 02:58:47PM +0900, Namhyung Kim escreveu: > > The sep is already checked being not NULL. The code seems to be a > > leftover from some refactoring. > > > > Signed-off-by: Namhyung Kim <namhy...@kernel.org> > > There is a missing --- separator from the description to the patch, I > had to add it so that 'git am' works on it, please check.
Hmm.. strange. I don't know why it's missed.. will double-check later. Thanks Namhyung > > - Arnaldo > > I.e. it should be right here: > > --- > > > > > diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c > > index 0a7fe4cb5555..10ab5e40a34f 100644 > > --- a/tools/perf/builtin-list.c > > +++ b/tools/perf/builtin-list.c > > @@ -92,13 +92,6 @@ int cmd_list(int argc, const char **argv) > > else if ((sep = strchr(argv[i], ':')) != NULL) { > > int sep_idx; > > > > - if (sep == NULL) { > > - print_events(argv[i], raw_dump, !desc_flag, > > - long_desc_flag, > > - details_flag, > > - deprecated); > > - continue; > > - } > > sep_idx = sep - argv[i]; > > s = strdup(argv[i]); > > if (s == NULL) > > -- > > 2.28.0.526.ge36021eeef-goog > > > > -- > > - Arnaldo