On Wed, Sep 09, 2020 at 10:32:53PM +0800, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/mfd/ene-kb3930.c:36:15: warning: > symbol 'kb3930_power_off' was not declared. Should it be static? > > This variable is not used outside of ene-kb3930.c, this commit > marks it static. > > Fixes: 753bd752e181 ("mfd: ene-kb3930: Add driver for ENE KB3930 Embedded > Controller") > Reported-by: Hulk Robot <hul...@huawei.com> > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
Acked-by: Lubomir Rintel <lkund...@v3.sk> Thank you! Lubo > --- > drivers/mfd/ene-kb3930.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/ene-kb3930.c b/drivers/mfd/ene-kb3930.c > index 1c32ff586816..eb7312bd6361 100644 > --- a/drivers/mfd/ene-kb3930.c > +++ b/drivers/mfd/ene-kb3930.c > @@ -33,7 +33,7 @@ struct kb3930 { > struct gpio_descs *off_gpios; > }; > > -struct kb3930 *kb3930_power_off; > +static struct kb3930 *kb3930_power_off; > > #define EC_GPIO_WAVE 0 > #define EC_GPIO_OFF_MODE 1 >