On 9/10/20 7:06 PM, Tianxianting wrote: > Hi viro, > Could I get your feedback? > This patch fixed the build warning, I think it can be applied, thanks :) > > -----Original Message----- > From: tianxianting (RD) > Sent: Saturday, September 05, 2020 3:15 PM > To: v...@zeniv.linux.org.uk > Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; tianxianting > (RD) <tian.xiant...@h3c.com> > Subject: [PATCH] fs: use correct parameter in notes of > generic_file_llseek_size() > > Fix warning when compiling with W=1: > fs/read_write.c:88: warning: Function parameter or member 'maxsize' not > described in 'generic_file_llseek_size' > fs/read_write.c:88: warning: Excess function parameter 'size' description in > 'generic_file_llseek_size' > > Signed-off-by: Xianting Tian <tian.xiant...@h3c.com>
Acked-by: Randy Dunlap <rdun...@infradead.org> Thanks. > --- > fs/read_write.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/read_write.c b/fs/read_write.c > index 5db58b8c7..058563ee2 100644 > --- a/fs/read_write.c > +++ b/fs/read_write.c > @@ -71,7 +71,7 @@ EXPORT_SYMBOL(vfs_setpos); > * @file: file structure to seek on > * @offset: file offset to seek to > * @whence: type of seek > - * @size: max size of this file in file system > + * @maxsize: max size of this file in file system > * @eof: offset used for SEEK_END position > * > * This is a variant of generic_file_llseek that allows passing in a custom > -- ~Randy
