Acked-by: mark gross <mgr...@linux.intel.com>
--mark
On Tue, Sep 15, 2020 at 12:09:23PM +0300, Necip Fazil Yildiran wrote:
> When LG_LAPTOP is enabled and NEW_LEDS is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for LEDS_CLASS
> Depends on [n]: NEW_LEDS [=n]
> Selected by [y]:
> - LG_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] &&
> ACPI_WMI [=y] && INPUT [=y]
>
> The reason is that LG_LAPTOP selects LEDS_CLASS without depending on or
> selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS.
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: dbf0c5a6b1f8 ("platform/x86: Add LG Gram laptop special features
> driver")
> Signed-off-by: Necip Fazil Yildiran <fazilyildi...@gmail.com>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 40219bba6801..81f6079d08e6 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1112,6 +1112,7 @@ config LG_LAPTOP
> depends on ACPI_WMI
> depends on INPUT
> select INPUT_SPARSEKMAP
> + select NEW_LEDS
> select LEDS_CLASS
> help
> This driver adds support for hotkeys as well as control of keyboard
> --
> 2.25.1
>
