On Thu, Sep 17, 2020 at 08:42:27AM +0930, Andrew Jeffery wrote: > > > On Thu, 17 Sep 2020, at 06:12, rentao.b...@gmail.com wrote: > > From: Tao Ren <rentao.b...@gmail.com> > > > > GPIO_U is mapped to the least significant byte of input/output mask, and > > the byte in "output" mask should be 0 because GPIO_U is input only. All > > the other bits need to be 1 because GPIO_V/W/X support both input and > > output modes. > > > > Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the > > according bits need to be 1 because GPIO_Y/Z support both input and > > output modes. > > > > Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed > > driver") > > Signed-off-by: Tao Ren <rentao.b...@gmail.com> > > Thanks Tao, > > Reviewed-by: Andrew Jeffery <and...@aj.id.au>
Thanks Andrew for the quick review. Cheers, Tao