Hi Greg, On 9/17/20 9:40 AM, Greg KH wrote:
On Wed, Sep 16, 2020 at 12:56:07PM -0700, Hemant Kumar wrote:+/** + * struct uci_dev - MHI uci device + * @minor: uci device node minor number + * @mhi_dev: associated mhi device object + * @chan: MHI channel name + * @lock: mutex lock + * @ul_chan: uplink uci channel object + * @dl_chan: downlink uci channel object + * @mtu: max tx buffer length + * @actual_mtu: maximum size of incoming buffer + * @open: open called for device node + * @enabled: uci device probed + * @ref_count: uci_dev reference count + */ +struct uci_dev { + unsigned int minor; + struct mhi_device *mhi_dev; + const char *chan; + + /* protects uci_dev struct members */ + struct mutex lock; + + struct uci_chan ul_chan; + struct uci_chan dl_chan; + size_t mtu; + size_t actual_mtu; + bool enabled; + struct kref ref_count; +};I don't think you actually made the kernel documentation based on these lines. Or if you did, you ignored the warnings :( Please test build your patches before sending them out...
Thanks for pointing out the kernel doc, it was a miss. i will fix it.
thanks, greg k-h
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
