________________________________________
发件人: Johannes Thumshirn <johannes.thumsh...@wdc.com>
发送时间: 2020年9月21日 16:52
收件人: Zhang, Qiang; c...@fb.com; jo...@toxicpanda.com; dste...@suse.com
抄送: linux-bt...@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH] btrfs: Fix missing close devices
On 21/09/2020 10:27, qiang.zh...@windriver.com wrote:
> From: Zqiang <qiang.zh...@windriver.com>
>
> When the btrfs fill super error, we should first close devices and
> then call deactivate_locked_super func to free fs_info.
>
> Signed-off-by: Zqiang <qiang.zh...@windriver.com>
> ---
> fs/btrfs/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index 8840a4fa81eb..3bfd54e8f388 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -1675,6 +1675,7 @@ static struct dentry *btrfs_mount_root(struct
> file_system_type *fs_type,
> error = security_sb_set_mnt_opts(s, new_sec_opts, 0, NULL);
> security_free_mnt_opts(&new_sec_opts);
> if (error) {
> + btrfs_close_devices(fs_devices);
> deactivate_locked_super(s);
> return ERR_PTR(error);
> }
>
>I think this is the fix for the syzkaller issue:
>Reported-by: syzbot+582e66e5edf36a22c...@syzkaller.appspotmail.com
Please try this patch.
