On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote:
> static int keyspan_open (struct usb_serial_port *port, struct file *filp)
> {
> struct keyspan_port_private *p_priv;
> struct keyspan_serial_private *s_priv;
> struct usb_serial *serial = port->serial;
> const struct keyspan_device_details *d_details;
> int i, err;
> struct urb *urb;
>
> s_priv = usb_get_serial_data(serial);
> p_priv = usb_get_serial_port_data(port);
> d_details = p_priv->device_details;
>
> dbg("%s - port%d.", __FUNCTION__, port->number);
>
> /* Set some sane defaults */
> p_priv->rts_state = 1;
> p_priv->dtr_state = 1;
> p_priv->baud = 9600;
>
> /* set CTS/RTS handshake etc. */
> p_priv->cflag = CS8; /* 8/N/1 */
> p_priv->flow_control = flow_none;
>
> /* force baud and lcr to be set on open */
> p_priv->old_baud = 0;
> p_priv->old_cflag = 0;
>
> p_priv->out_flip = 0;
> p_priv->in_flip = 0;
>
> /* Reset low level data toggle and start reading from endpoints */
> for (i = 0; i < 2; i++) {
> if ((urb = p_priv->in_urbs[i]) == NULL)
> continue;
> urb->dev = serial->dev;
>
> /* make sure endpoint data toggle is synchronized with the
> device */
>
> usb_clear_halt(urb->dev, urb->pipe);
>
> if ((err = usb_submit_urb(urb, GFP_KERNEL)) != 0) {
> dbg("%s - submit urb %d failed (%d)", __FUNCTION__, i,
> err);
> }
> }
>
> /* Reset low level data toggle on out endpoints */
> for (i = 0; i < 2; i++) {
> if ((urb = p_priv->out_urbs[i]) == NULL)
> continue;
> urb->dev = serial->dev;
> /* usb_settoggle(urb->dev, usb_pipeendpoint(urb->pipe),
> usb_pipeout(urb->pipe), 0); */
> }
>
> keyspan_send_setup(port, 1);
> //mdelay(100);
> //keyspan_set_termios(port, NULL);
>
> return (0);
> }
>
yes, after testing this i can confirm that this one fixes the NULL ptr
problem here so you might want to submit a proper patch to Greg.
--
Regards/Gruß,
Boris.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
