IMHO, WARN_ON_ONCE() looks ok to me. as long as it won't crash the system or lead to any memory corruption issue. We can talk about the reproducer offline if you are interested. - Tong
On Wed, Sep 23, 2020 at 1:06 AM Christoph Hellwig <[email protected]> wrote: > > On Tue, Sep 22, 2020 at 04:34:45PM -0400, Tong Zhang wrote: > > Hi Christoph, > > I modified the patch a bit and now it works. > > So you're still hitting the WARN_ON_ONCE? I think we need to fix that > as well, but all the ideas I have will turn into a bigger project, > so I think I'll submit this one to Jens, and then do things > incrementally. > > Can you share your reproducer?

