Hi Pali, > On Tuesday 08 September 2020 09:47:33 Pali Rohár wrote: >> On Monday 07 September 2020 19:23:45 Andrew Lunn wrote: >> > On Mon, Sep 07, 2020 at 06:13:16PM +0200, Pali Rohár wrote: >> > > On Monday 07 September 2020 17:43:53 Andrew Lunn wrote: >> > > > > I would not say it is a "new feature". But rather that patch in this >> > > > > email fixes issue that Linux kernel did not set correct MAC address >> > > > > for >> > > > > DSA slave ports. I think it is something which could be backported >> > > > > also >> > > > > to stable releases as "ignoring" vendor/factory MAC address is not >> > > > > correct behavior. >> > > > >> > > > Hi Pali >> > > > >> > > > The rules for stable are here: >> > > > >> > > > https://www.kernel.org/doc/html/v5.8/process/stable-kernel-rules.html >> > > > >> > > > Do you think it fits? >> > > > >> > > > Andrew >> > > >> > > Hello Andrew! I think it fits into those rules. As I wrote it fixes real >> > > bug that Linux kernel does not use correct MAC address for particular >> > > DSA slaves / ethernet ports. >> > >> > O.K, then: >> > >> > Reviewed-by: Andrew Lunn <and...@lunn.ch> >> > >> > Andrew >> >> Ok! Andrew, I would like to ask another question, how to correctly >> define that this patch depends on a2c7023f7075c? I specified it in >> human-readable part of commit description, but for backporting it would >> also need some machine-readable format. So patch would not be >> occasionally backported to older/stable kernel where a2c7023f7075c is >> not available. > > Based on stable-kernel-rules.html document I think that following line > should define this dependency in machine readable format: > > Cc: <sta...@vger.kernel.org> # a2c7023f7075c: dsa: read mac address > > Gregory, if it is correct, would you add that line into commit sign-off > area where is existing Fixes: line?
I amended the commit log with this change. Thanks, Gregory -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com