On Wed, Sep 23, 2020 at 1:12 PM Andy Shevchenko <[email protected]> wrote: >
[snip!] > > > + /* Bias requires explicit direction. */ > > + if ((flags & GPIO_V2_LINE_BIAS_FLAGS) && > > + !(flags & GPIO_V2_LINE_DIRECTION_FLAGS)) > > + return -EINVAL; > > Okay, since this is strict we probably may relax it in the future if > it will be a use case. > ... > > > + /* Only one bias flag can be set. */ > > Ditto. (Some controllers allow to set both simultaneously, though I > can't imagine good use case for that) > This is an abstraction layer. Only because some controllers allow this, doesn't mean we should reflect this in our abstraction layer - especially if we know well that this has no purpose. Bartosz
