On Thu, Sep 24, 2020 at 07:33:59AM -0700, Guenter Roeck wrote: > On 9/24/20 7:12 AM, Li Heng wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/usb/typec/tcpm/tcpm.c:1620:39: warning: > > ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=] > > > > Reported-by: Hulk Robot <[email protected]> > > Signed-off-by: Li Heng <[email protected]> > > I thought there was a patch series underway which started using it, > but maybe my memory defeats me. Either case, it doesn't make much sense > to remove the ops variable without removing the associated functions > as well.
I agree, if this isn't needed, then the functions here should also be removed in the same patch. thanks, greg k-h
