On 10/3/20 10:14 PM, Moritz Fischer wrote: > Simplify registration using new devm_fpga_mgr_register() API. > > Signed-off-by: Moritz Fischer <m...@kernel.org> > --- > drivers/fpga/dfl-fme-mgr.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c > index b3f7eee3c93f..3fc2be87d059 100644 > --- a/drivers/fpga/dfl-fme-mgr.c > +++ b/drivers/fpga/dfl-fme-mgr.c > @@ -316,16 +316,7 @@ static int fme_mgr_probe(struct platform_device *pdev) > mgr->compat_id = compat_id; > platform_set_drvdata(pdev, mgr);
Is this call is still needed ? Tom > > - return fpga_mgr_register(mgr); > -} > - > -static int fme_mgr_remove(struct platform_device *pdev) > -{ > - struct fpga_manager *mgr = platform_get_drvdata(pdev); > - > - fpga_mgr_unregister(mgr); > - > - return 0; > + return devm_fpga_mgr_register(dev, mgr); > } > > static struct platform_driver fme_mgr_driver = { > @@ -333,7 +324,6 @@ static struct platform_driver fme_mgr_driver = { > .name = DFL_FPGA_FME_MGR, > }, > .probe = fme_mgr_probe, > - .remove = fme_mgr_remove, > }; > > module_platform_driver(fme_mgr_driver);