> +++ 2.6.x-xfs-new/fs/xfs/xfs_inode.c 2007-11-22 10:33:51.037704348 +1100 > @@ -183,12 +183,20 @@ xfs_imap_to_bp( > int ni; > xfs_buf_t *bp; > > + if (buf_flags == 0) > + buf_flags = XFS_BUF_LOCK;
There's just two caller and they never pass 0, so this is not needed. > + error = xfs_itobp_flags(mp, NULL, ip, &dip, &bp, 0, 0, > + (noblock) ? XFS_BUF_TRYLOCK : XFS_BUF_LOCK); no need for the braces around noblock. > +int xfs_itobp_flags(struct xfs_mount *, struct xfs_trans *, > xfs_inode_t *, struct xfs_dinode **, struct xfs_buf > **, > - xfs_daddr_t, uint); > + xfs_daddr_t, uint, uint); > +#define xfs_itobp(mp, tp, ip, dipp, bpp, bno, iflags) \ > + xfs_itobp_flags(mp, tp, ip, dipp, bpp, bno, iflags, XFS_BUF_LOCK) I'd say just convert xfs_itobp and all it's user to take the additional argument. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
