On Mon, Oct 05, 2020 at 10:52:12PM +0800, Tianjia Zhang wrote:
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
Thanks! In my tree for the next release.
-corey
>
> Fixes: 90b2d4f15ff7 ("ipmi_si: Remove hacks for adding a dummy platform
> devices")
> Cc: Corey Minyard <cminy...@mvista.com>
> Signed-off-by: Tianjia Zhang <tianjia.zh...@linux.alibaba.com>
> ---
> drivers/char/ipmi/ipmi_si_intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c
> b/drivers/char/ipmi/ipmi_si_intf.c
> index 77b8d551ae7f..dd559661c15b 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -1963,7 +1963,7 @@ static int try_smi_init(struct smi_info *new_smi)
> /* Do this early so it's available for logs. */
> if (!new_smi->io.dev) {
> pr_err("IPMI interface added with no device\n");
> - rv = EIO;
> + rv = -EIO;
> goto out_err;
> }
>
> --
> 2.24.3 (Apple Git-128)
>
