The node names for devices using the pwm-leds driver follow a certain
naming scheme (now).  Parent node name is not enforced, but recommended
by DT project.

  DTC     arch/arm/boot/dts/imx53-ppd.dt.yaml
  CHECK   arch/arm/boot/dts/imx53-ppd.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/imx53-ppd.dt.yaml: leds-brightness: 
'alarm-brightness' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 
'pinctrl-[0-9]+'
        From schema: 
/home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
  DTC     arch/arm/boot/dts/imx6dl-cubox-i.dt.yaml
  CHECK   arch/arm/boot/dts/imx6dl-cubox-i.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/imx6dl-cubox-i.dt.yaml: pwmleds: 
'front' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 
'pinctrl-[0-9]+'
        From schema: 
/home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
  DTC     arch/arm/boot/dts/imx6dl-cubox-i-emmc-som-v15.dt.yaml
  CHECK   arch/arm/boot/dts/imx6dl-cubox-i-emmc-som-v15.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/imx6dl-cubox-i-emmc-som-v15.dt.yaml: 
pwmleds: 'front' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 
'pinctrl-[0-9]+'
        From schema: 
/home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
  DTC     arch/arm/boot/dts/imx6dl-cubox-i-som-v15.dt.yaml
  CHECK   arch/arm/boot/dts/imx6dl-cubox-i-som-v15.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/imx6dl-cubox-i-som-v15.dt.yaml: 
pwmleds: 'front' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 
'pinctrl-[0-9]+'
        From schema: 
/home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
  DTC     arch/arm/boot/dts/imx6sx-softing-vining-2000.dt.yaml
  CHECK   arch/arm/boot/dts/imx6sx-softing-vining-2000.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/imx6sx-softing-vining-2000.dt.yaml: 
pwmleds: 'blue', 'green', 'red' do not match any of the regexes: 
'^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
        From schema: 
/home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml

Signed-off-by: Alexander Dahl <p...@lespocky.de>
---

Notes:
    v6 -> v7:
      * split up patch (one per sub arch)
      * added actual warnings to commit message

 arch/arm/boot/dts/imx53-ppd.dts                  | 15 ++++++++-------
 arch/arm/boot/dts/imx6qdl-cubox-i.dtsi           |  4 ++--
 arch/arm/boot/dts/imx6sx-softing-vining-2000.dts |  8 ++++----
 3 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-ppd.dts b/arch/arm/boot/dts/imx53-ppd.dts
index f7dcdf96e5c0..b480614efb30 100644
--- a/arch/arm/boot/dts/imx53-ppd.dts
+++ b/arch/arm/boot/dts/imx53-ppd.dts
@@ -176,36 +176,37 @@
                power-supply = <&reg_3v3_lcd>;
        };
 
-       leds-brightness {
+       led-controller-1 {
                compatible = "pwm-leds";
 
-               alarm-brightness {
+               led-1 {
+                       label = "alarm-brightness";
                        pwms = <&pwm1 0 100000>;
                        max-brightness = <255>;
                };
        };
 
-       leds {
+       led-controller-2 {
                compatible = "gpio-leds";
                pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_alarmled_pins>;
 
-               alarm1 {
+               led-2 {
                        label = "alarm:red";
                        gpios = <&gpio7 3 GPIO_ACTIVE_HIGH>;
                };
 
-               alarm2 {
+               led-3 {
                        label = "alarm:yellow";
                        gpios = <&gpio7 7 GPIO_ACTIVE_HIGH>;
                };
 
-               alarm3 {
+               led-4 {
                        label = "alarm:blue";
                        gpios = <&gpio7 8 GPIO_ACTIVE_HIGH>;
                };
 
-               alarm4 {
+               led-5 {
                        label = "alarm:silenced";
                        gpios = <&gpio7 13 GPIO_ACTIVE_HIGH>;
                };
diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi 
b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
index 67042793b0ca..1e530d892b76 100644
--- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
@@ -55,12 +55,12 @@
                pinctrl-0 = <&pinctrl_cubox_i_ir>;
        };
 
-       pwmleds {
+       led-controller {
                compatible = "pwm-leds";
                pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_cubox_i_pwm1>;
 
-               front {
+               led-1 {
                        active-low;
                        label = "imx6:red:front";
                        max-brightness = <248>;
diff --git a/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts 
b/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
index d25e27d0315f..83bff1a129ec 100644
--- a/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
+++ b/arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
@@ -40,22 +40,22 @@
                regulator-max-microvolt = <3300000>;
        };
 
-       pwmleds {
+       led-controller {
                compatible = "pwm-leds";
 
-               red {
+               led-1 {
                        label = "red";
                        max-brightness = <255>;
                        pwms = <&pwm6 0 50000>;
                };
 
-               green {
+               led-2 {
                        label = "green";
                        max-brightness = <255>;
                        pwms = <&pwm2 0 50000>;
                };
 
-               blue {
+               led-3 {
                        label = "blue";
                        max-brightness = <255>;
                        pwms = <&pwm1 0 50000>;
-- 
2.20.1

Reply via email to