On Tue, Oct 06, 2020 at 04:55:27PM +0100, Qais Yousef wrote: > > +int cpumask_any_distribute(const struct cpumask *srcp) > > +{ > > + int next, prev; > > + > > + /* NOTE: our first selection will skip 0. */ > > + prev = __this_cpu_read(distribute_cpu_mask_prev); > > We had a discussion then that __this_cpu*() variant assumes preemption being > disabled and it's safer to use this_cpu*() variant instead. Still holds true > here?
I think we ended up with not caring. We wanted a 'random' value, we get a 'random' value from a 'random' CPU, still works ;-)