Hi ,
>-----Original Message----- >From: Andy Shevchenko <[email protected]> >Sent: Wednesday, October 7, 2020 10:55 PM >To: Zulkifli, Muhammad Husaini <[email protected]> >Cc: Michal Simek <[email protected]>; Hunter, Adrian ><[email protected]>; Sudeep Holla <[email protected]>; Ulf >Hansson <[email protected]>; linux-mmc <[email protected]>; >linux-arm Mailing List <[email protected]>; Linux Kernel >Mailing List <[email protected]>; Raja Subramanian, Lakshmi Bai ><[email protected]>; Wan Mohamad, Wan Ahmad Zainie ><[email protected]>; Arnd Bergmann ><[email protected]> >Subject: Re: [PATCH v3 1/2] mmc: sdhci-of-arasan: Enable UHS-1 support for >Keem Bay SOC > >On Wed, Oct 7, 2020 at 4:28 PM Zulkifli, Muhammad Husaini ><[email protected]> wrote: >> >From: Andy Shevchenko <[email protected]> >> >Sent: Wednesday, October 7, 2020 4:56 PM On Wed, Oct 7, 2020 at 11:38 >> >AM Michal Simek <[email protected]> >> >wrote: >> >> On 06. 10. 20 17:55, [email protected] wrote: > >... > >> >> > + struct device *dev = &pdev->dev; >> >> >> >> nit: I got this but as I see 3 lines below maybe would be better to >> >> use it everywhere but it can be done in separate patch. >> > >> >In that case I think it would be better to have that patch first. It >> >make follow up code cleaner. >> I want to get some clarification here. > >> Do I need a separate patch for this struct device *dev = &pdev->dev;? > >It should be a separate patch and better your series starts with it, so it >won't >interfere with new code. > >> Can I embedded together with UHS patch? > >Better to avoid merging orthogonal things together in one change. Noted. Thanks 😉 > >-- >With Best Regards, >Andy Shevchenko
