Hi Andrey, I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing] [also build test ERROR on vhost/linux-next hnaz-linux-mm/master linus/master v5.9-rc8 next-20201009] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andrey-Konovalov/kcov-usb-vhost-specify-contexts-for-remote-coverage-sections/20201009-205923 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: x86_64-rhel-8.3 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/669e3ded7b025bc4f34c158e66974ff11f452a88 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andrey-Konovalov/kcov-usb-vhost-specify-contexts-for-remote-coverage-sections/20201009-205923 git checkout 669e3ded7b025bc4f34c158e66974ff11f452a88 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/vhost/vhost.c: In function 'vhost_worker': >> drivers/vhost/vhost.c:367:8: error: 'KCOV_CONTEXT_TASK' undeclared (first >> use in this function) 367 | KCOV_CONTEXT_TASK); | ^~~~~~~~~~~~~~~~~ drivers/vhost/vhost.c:367:8: note: each undeclared identifier is reported only once for each function it appears in -- drivers/usb/core/hub.c: In function 'hub_event': >> drivers/usb/core/hub.c:5526:48: error: 'KCOV_CONTEXT_TASK' undeclared (first >> use in this function) 5526 | kcov_remote_start_usb((u64)hdev->bus->busnum, KCOV_CONTEXT_TASK); | ^~~~~~~~~~~~~~~~~ drivers/usb/core/hub.c:5526:48: note: each undeclared identifier is reported only once for each function it appears in -- drivers/usb/core/hcd.c: In function '__usb_hcd_giveback_urb': >> drivers/usb/core/hcd.c:1649:52: error: 'KCOV_CONTEXT_SOFTIRQ' undeclared >> (first use in this function) 1649 | kcov_remote_start_usb((u64)urb->dev->bus->busnum, KCOV_CONTEXT_SOFTIRQ); | ^~~~~~~~~~~~~~~~~~~~ drivers/usb/core/hcd.c:1649:52: note: each undeclared identifier is reported only once for each function it appears in vim +/KCOV_CONTEXT_TASK +367 drivers/vhost/vhost.c 338 339 static int vhost_worker(void *data) 340 { 341 struct vhost_dev *dev = data; 342 struct vhost_work *work, *work_next; 343 struct llist_node *node; 344 345 kthread_use_mm(dev->mm); 346 347 for (;;) { 348 /* mb paired w/ kthread_stop */ 349 set_current_state(TASK_INTERRUPTIBLE); 350 351 if (kthread_should_stop()) { 352 __set_current_state(TASK_RUNNING); 353 break; 354 } 355 356 node = llist_del_all(&dev->work_list); 357 if (!node) 358 schedule(); 359 360 node = llist_reverse_order(node); 361 /* make sure flag is seen after deletion */ 362 smp_wmb(); 363 llist_for_each_entry_safe(work, work_next, node, node) { 364 clear_bit(VHOST_WORK_QUEUED, &work->flags); 365 __set_current_state(TASK_RUNNING); 366 kcov_remote_start_common(dev->kcov_handle, > 367 > KCOV_CONTEXT_TASK); 368 work->fn(work); 369 kcov_remote_stop(KCOV_CONTEXT_TASK); 370 if (need_resched()) 371 schedule(); 372 } 373 } 374 kthread_unuse_mm(dev->mm); 375 return 0; 376 } 377 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
