Hi Bhanu, Thank you for your patch.
On 9/10/20 23:01, Bhanu Prakash Maiya wrote: > Add DT compatible string in > Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > The problem with this patchset continues being the same. You are using the trick of using a DT compatible string to instantiate an ACPI-only driver. You should have an ACPI ID for that device or use a DMI table to match the device and instantiate it (see for example the platform/chrome/cros_ec_lpc.c). Thanks, Enric > Signed-off-by: Bhanu Prakash Maiya <bhanuma...@chromium.org> > Reviewed-by: Rob Herring <r...@kernel.org> > --- > > Changes in v6: > - No change > > Changes in v5: > - No change > > Changes in v4: > - Changes in commit message. > > Changes in v3: > - Rebased changes on google,cros-ec.yaml > > Changes in v2: > - No change > > Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > index 6a7279a85ec1c..552d1c9bf3de4 100644 > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > @@ -10,11 +10,12 @@ maintainers: > - Benson Leung <ble...@chromium.org> > - Enric Balletbo i Serra <enric.balle...@collabora.com> > - Guenter Roeck <gro...@chromium.org> > + - Bhanu Prakash Maiya <bhanuma...@chromium.org> > > description: > Google's ChromeOS EC is a microcontroller which talks to the AP and > implements various functions such as keyboard and battery charging. > - The EC can be connected through various interfaces (I2C, SPI, and others) > + The EC can be connected through various interfaces (I2C, SPI, UART and > others) > and the compatible string specifies which interface is being used. > > properties: > @@ -29,6 +30,9 @@ properties: > - description: > For implementations of the EC is connected through RPMSG. > const: google,cros-ec-rpmsg > + - description: > + For implementations of the EC is connected through UART. > + const: google,cros-ec-uart > > google,cros-ec-spi-pre-delay: > description: >
