On Sun, 25 Nov 2007 11:21:45 +0100 Prakash Punnoor <[EMAIL PROTECTED]> wrote:
> Yay: Sounds good. > One thing I noticed in the patch: > + if (((bridge_dev = pci_find_slot(0, 0)) != NULL) && > > You rather want to use pci_get_bus_and_slot instead, as pci_find_slot is > deprecated. yup. I'll queue this to get it a bit of testing but won't send it to Greg, in the expectation that an updated version will be prepared. Please do feed the diff through scripts/checkpatch.pl too - there are a large number of trivial coding-style glitches in there. Also, your [patch 1/2] will break the build unless your [patch 2/2] is applied. This will break git bisection so please avoid it. It is appropriate to fold both these patches into a single one. And please avoid sending multiple patches under the same title, as these two were. Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
