On 10/9/20 9:54 PM, Kees Cook wrote:
Instead of repeating "Redzone" and "Poison", clarify which sides of those zones got tripped. Additionally fix column alignment in the trailer.Before: BUG test (Tainted: G B ): Redzone overwritten ... Redzone (____ptrval____): bb bb bb bb bb bb bb bb ........ Object (____ptrval____): f6 f4 a5 40 1d e8 ...@.. Redzone (____ptrval____): 1a aa .. Padding (____ptrval____): 00 00 00 00 00 00 00 00 ........ After: BUG test (Tainted: G B ): Right Redzone overwritten ... Redzone (____ptrval____): bb bb bb bb bb bb bb bb ........ Object (____ptrval____): f6 f4 a5 40 1d e8 ...@.. Redzone (____ptrval____): 1a aa .. Padding (____ptrval____): 00 00 00 00 00 00 00 00 ........ Fixes: d86bd1bece6f ("mm/slub: support left redzone") Fixes: ffc79d288000 ("slub: use print_hex_dump") Fixes: 2492268472e7 ("SLUB: change error reporting format to follow lockdep loosely")
Not sure about those Fixes: tag as this is mainly an enhancement. I'd only use those for real bug fixes.
Signed-off-by: Kees Cook <keesc...@chromium.org>
Acked-by: Vlastimil Babka <vba...@suse.cz>
