Hi Geert, Thank you for your feedback!
> From: Geert Uytterhoeven <ge...@linux-m68k.org> > Sent: 14 October 2020 14:40 > Subject: Re: [PATCH v3 2/5] media: dt-bindings: media: renesas,drif: Convert > to json-schema > > Hi Fabrizio, > > On Tue, Oct 13, 2020 at 5:02 PM Fabrizio Castro > <fabrizio.castro...@renesas.com> wrote: > > Convert the Renesas DRIF bindings to DT schema and update > > MAINTAINERS accordingly. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro...@renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev- > lad...@bp.renesas.com> > > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > > --- > > v2->3: > > * Removed the definition of pinctrl-0 and pinctrl-names, as > > suggested by Geert > > * Added "power-domains" to the list of required properties, > > as suggested by Geert > > * Reworked the conditional requirements, Geert, what do you > > think? > > Thanks for the update! > > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml > > > +allOf: > > + - if: > > + required: > > + - renesas,primary-bond > > + then: > > + required: > > + - pinctrl-0 > > + - pinctrl-names > > + - port > > + > > + - if: > > + required: > > + - port > > + then: > > + required: > > + - pinctrl-0 > > + - pinctrl-names > > + > > + - if: > > + not: > > + required: > > + - port > > + then: > > This can just be an "else" branch for the previous "if" statement? Yes, it's equivalent. I'll send out v4 to tackle this. Thanks, Fab > > > + properties: > > + pinctrl-0: false > > + pinctrl-names: false > > With the above fixed/clarified: > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647