On Wed, Oct 14, 2020 at 04:52:23PM +0200, Thomas Gleixner wrote: > From: Ahmed S. Darwish <[email protected]> > > The usage of in_interrupt() in drivers is phased out for various reasons. > > Various comments use !in_interrupt() to describe calling context for probe() > and remove() functions. That's wrong because the calling context has to be > preemptible task context, which is not what !in_interrupt() describes. > > Cleanup the comments. While at it add the missing kernel doc argument > descriptors and make usb_hcd_msp_remove() static. > > Signed-off-by: Ahmed S. Darwish <[email protected]> > Signed-off-by: Sebastian Andrzej Siewior <[email protected]> > Signed-off-by: Thomas Gleixner <[email protected]> > Cc: Alan Stern <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: Kukjin Kim <[email protected]> > Cc: Krzysztof Kozlowski <[email protected]> > Cc: [email protected] > Cc: [email protected] > > ---
> --- a/drivers/usb/host/ehci-pmcmsp.c > +++ b/drivers/usb/host/ehci-pmcmsp.c > @@ -233,7 +236,7 @@ int usb_hcd_msp_probe(const struct hc_dr > * may be called without controller electrically present > * may be called with controller, bus, and devices active > */ > -void usb_hcd_msp_remove(struct usb_hcd *hcd, struct platform_device *dev) > +static void usb_hcd_msp_remove(struct usb_hcd *hcd) Please don't intermix changes to comments with other more substantive changes. > --- a/drivers/usb/host/ohci-omap.c > +++ b/drivers/usb/host/ohci-omap.c > @@ -399,8 +401,7 @@ static int ohci_hcd_omap_probe(struct pl > > /** > * ohci_hcd_omap_remove - shutdown processing for OMAP-based HCDs > - * @dev: USB Host Controller being removed > - * Context: !in_interrupt() > + * @pdev: USB Host Controller being removed > * > * Reverses the effect of ohci_hcd_omap_probe(), first invoking > * the HCD's stop() method. It is always called from a thread You forgot to add the Context comment. Alan Stern
