On Tuesday 27 November 2007, eric miao wrote: > status = chip->direction_input(chip, gpio); > - if (status == 0) > - clear_bit(gpio, chip->is_out); > + if (status) > + desc->is_out = 0;
You added that same bug in two places (direction_output too). Only zero status means success; otherwise it's negative errno. Clearly this patch wasn't tested at all. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
