On Sat, Oct 17, 2020 at 10:03 PM Joe Perches <[email protected]> wrote: > > On Sat, 2020-10-17 at 21:57 +0530, Dwaipayan Ray wrote: > > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") > > moved the repeated word test to check for more file types. But after > > this, if checkpatch.pl is run on MAINTAINERS, it generates several > > new warnings of the type: > > NAK. > > Slow down and test before you send more patch versions. > > > + next if (index(" \t.,;?!", $end_char) == -1); > > what does this do?
Um, it checks if end_char is not present in " \t.,;?!". If end_char doesn't belong to this list, then the check shall skip. That is the test will skip for "word word:", but will produce a warning for "word word." or "word word?", etc. Shouldn't this itself be the case or am I perhaps going wrong somewhere? Thanks, Dwaipayan.
