On Sat, Oct 17, 2020 at 11:21:51AM -0700, Linus Torvalds wrote:
> On Fri, Oct 16, 2020 at 11:52 AM Jason Gunthorpe <j...@nvidia.com> wrote:
> >
> > You'll need to apply this fixup to the merge commit (it is in the tag
> > for-linus-merged for reference):
> 
> Ugh. That's unbelievably and unnecessarily ugly.
> 
> There's no point in that unnecessary "ret" variable and the "goto out"
> etc, when all the error cases can be handled much more directly.

Yep

> So I resolved that merge issue somewhat differently. I can't test the
> end result, but it looks TriviallyCorrect(tm).
> 
> Famous last words. Feel free to make fun of me and call me names if that 
> breaks.

Not familiar with DRM land, but it looks trivially fine to me too.

Thanks,
Jason

Reply via email to