Hi Tom, On Fri, 16 Oct 2020 16:48:21 -0500 Tom Zanussi <zanu...@kernel.org> wrote:
> Hi, > > This patchset addresses the synthetic event error anomalies reported > by Masami in the last patchset [1]. > > It turns out that most of the problems boil down to clunky separator > parsing; adding a couple new abilities to trace_run_command() and then > adapting the existing users seemed to me the best way to fix these > things, and also gets rid of some code. Thanks for your work! But I think the interface design is a bit add-hoc. I sent a comment mail on [1/4]. Let's discuss on the thread. > Also, to make things easier for error display, I changed these to > preserve the original command string and pass it through the callback > instead of rebuilding it for error display. trace_*probe reconstruct the input from argv, are there any reason synthetic event can not do the same thing? (this means the command on error message can be a bit different, see __trace_probe_log_err() in kernel/trace/trace_probe.c) > > I added some new error strings and removed unused ones as well, and > added a bunch of new test cases to the synthetic parser error test > case. Good. > > I didn't see any problems running the entire ftrace testsuite or the > test modules that also use the things that were touched here. Thanks, > > Thanks, > > Tom > > [1] > https://lore.kernel.org/lkml/20201014110636.139df7be275d40a23b523...@kernel.org/ > > The following changes since commit 6107742d15832011cd0396d821f3225b52551f1f: > > tracing: support "bool" type in synthetic trace events (2020-10-15 12:01:14 > -0400) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git > ftrace/synth-fixes-v1 > > Tom Zanussi (4): > tracing: Make trace_*_run_command() more flexible > tracing: Use new trace_run_command() options > tracing: Update synth command errors > selftests/ftrace: Update synthetic event syntax errors > > kernel/trace/trace.c | 41 ++++++++-- > kernel/trace/trace.h | 12 ++- > kernel/trace/trace_dynevent.c | 4 +- > kernel/trace/trace_events_synth.c | 79 ++++--------------- > kernel/trace/trace_kprobe.c | 5 +- > kernel/trace/trace_uprobe.c | 5 +- > .../trigger-synthetic_event_syntax_errors.tc | 17 ++-- > 7 files changed, 78 insertions(+), 85 deletions(-) > > -- > 2.17.1 > -- Masami Hiramatsu <mhira...@kernel.org>
