The 10/21/2020 12:14, Johannes Thumshirn wrote: > On 21/10/2020 11:04, Sergei Shtepa wrote: > > + help > > + Enabling this lets third-party kernel modules intercept > > + bio requests for any block device. This allows them to implement > > The "third-party kernel modules" part sounds a bit worrisome to me. Especially > as this functionality is based on EXPORT_SYMBOL()s without the GPL suffix. > > I read it as a "allow a proprietary module to mess with bios", which is a big > no-no to me. > > Not providing any sort of changelog doesn't help much either. > > Thanks, > Johannes >
I think the words "third-party" are is not necessary. In my opinion, creating proprietary kernel modules for Linux is an empty idea. EXPORT_SYMBOL() -> EXPORT_SYMBOL_GPL() - no problem. -- Sergei Shtepa Veeam Software developer.
