Hi Prashant,

On Wed, Oct 21, 2020 at 02:18:02PM -0700, Prashant Malani wrote:
> A PD-capable device can return up to 3 Product Type VDOs as part of its
> DiscoverIdentity Response (USB PD Spec, Rev 3.0, Version 2.0, Section
> 6.4.4.3.1). Add a sysfs attribute to expose these to userspace.
> 
> Cc: Benson Leung <ble...@chromium.org>
> Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com>
> Signed-off-by: Prashant Malani <pmal...@chromium.org>

Reviewed-by: Benson Leung <ble...@chromium.org>

> ---
>  drivers/usb/typec/class.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 35eec707cb51..e6abb0dee9fa 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -122,10 +122,20 @@ static ssize_t product_show(struct device *dev, struct 
> device_attribute *attr,
>  }
>  static DEVICE_ATTR_RO(product);
>  
> +static ssize_t product_type_vdo_show(struct device *dev, struct 
> device_attribute *attr,
> +                                  char *buf)
> +{
> +     struct usb_pd_identity *id = get_pd_identity(dev);
> +
> +     return sprintf(buf, "0x%08x\n0x%08x\n0x%08x\n", id->vdo[0], id->vdo[1], 
> id->vdo[2]);
> +}
> +static DEVICE_ATTR_RO(product_type_vdo);
> +
>  static struct attribute *usb_pd_id_attrs[] = {
>       &dev_attr_id_header.attr,
>       &dev_attr_cert_stat.attr,
>       &dev_attr_product.attr,
> +     &dev_attr_product_type_vdo.attr,
>       NULL
>  };
>  
> -- 
> 2.29.0.rc1.297.gfa9743e501-goog
> 

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org

Attachment: signature.asc
Description: PGP signature

Reply via email to