Hello Peter, > -----Original Message----- > From: Peter Korsgaard <[email protected]> On Behalf Of Peter Korsgaard > Sent: Wednesday, October 21, 2020 9:16 PM > To: Sagar Kadam <[email protected]> > Cc: [email protected]; [email protected]; linux- > [email protected]; [email protected]; Paul Walmsley ( Sifive) > <[email protected]>; [email protected]; > [email protected] > Subject: Re: [PATCH v4 1/1] i2c: ocores: fix polling mode workaround on > FU540-C000 SoC > > [External Email] Do not click links or attachments unless you recognize the > sender and know the content is safe > > >>>>> "Sagar" == Sagar Shrikant Kadam <[email protected]> writes: > > > The FU540-C000 has a broken IRQ and support was added earlier > > so that it will operate in polling mode, but seems to work only > > in case interrupts property is missing from the i2c0 dt-node. > > This should not be the case and the driver should handle polling > > mode with the interrupt property present in i2c0 node of the > > device tree. > > So check if it's the FU540-C000 soc and enable polling mode master > > xfers, as the IRQ for this chip is broken. > > > Fixes commit c45d4ba86731 ("i2c: ocores: add polling mode workaround > > for Sifive FU540-C000 SoC") > > > Signed-off-by: Sagar Shrikant Kadam <[email protected]> > > LGTM, thanks. > > Acked-by: Peter Korsgaard <[email protected]> >
Thank you for the review and "Acked-by" BR, Sagar > -- > Bye, Peter Korsgaard
