On Thu, Sep 17, 2020 at 08:39:49PM +0800, Qinglang Miao wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Qinglang Miao <[email protected]> > --- > v2: based on linux-next(20200917), and can be applied to > mainline cleanly now. > > drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > index 1d767473b..4a10e6b9e 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > @@ -41,18 +41,7 @@ static int komeda_register_show(struct seq_file *sf, void > *x) > return 0; > } > > -static int komeda_register_open(struct inode *inode, struct file *filp) > -{ > - return single_open(filp, komeda_register_show, inode->i_private); > -} > - > -static const struct file_operations komeda_register_fops = { > - .owner = THIS_MODULE, > - .open = komeda_register_open, > - .read = seq_read, > - .llseek = seq_lseek, > - .release = single_release, > -}; > +DEFINE_SHOW_ATTRIBUTE(komeda_register);
Hi Qinglang, Sorry for the belated response! Acked-by: Liviu Dudau <[email protected]> Best regards, Liviu > > #ifdef CONFIG_DEBUG_FS > static void komeda_debugfs_init(struct komeda_dev *mdev) > -- > 2.23.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
