On Fri, 23 Oct 2020 14:32:36 +1100 Michael Ellerman wrote: > Clang warns about the extra parentheses in this comparison: > > drivers/net/ethernet/freescale/ucc_geth.c:1361:28: > warning: equality comparison with extraneous parentheses > if ((ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII)) > ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > It seems clear the intent here is to do a comparison not an > assignment, so drop the extra parentheses to avoid any confusion. > > Signed-off-by: Michael Ellerman <m...@ellerman.id.au>
Applied, thanks!
