On Sat, Oct 24, 2020 at 04:13:15PM +0900, Masami Hiramatsu wrote:
> Thanks, so will you split this into several patches, since I saw some
> cleanups in this patch?
Oh, most definitely. This was just a preview of where this is going...
> Yeah, that's good to me because in the most cases, user needs prefix,
> length or total decoded info.
>
> BTW, it seems you returns 1 for errors, I rather like -EINVAL or -EILSEQ
> for errors so that user can also write
>
> if (insn_decode() < 0)
> ...
>
> I think "positive" and "zero" pair can easily mislead user to "true" and
> "false" trap.
Ok, sure, makes sense.
> Yeah, for the kprobes, if you see the insn_init() and insn_get_length()
> those can be replaced with one insn_decode().
Ok.
> Except for the return value, it looks good to me.
Thanks!
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
