+ Yong Mao, Chaotian Jing On Fri, 23 Oct 2020 at 14:29, Fabien Parent <fpar...@baylibre.com> wrote: > > MT8516 SoC suffers from sometimes losing SDIO IRQs, this makes SDIO > devices sometimes unstable. Make use of the new property > recheck_sdio_irq to fix the SDIO stability issues on MT8516. > > Signed-off-by: Fabien Parent <fpar...@baylibre.com>
Maybe this is a common problem, thus I am thinking that potentially we should enable the workaround for all variants? I have looped in Yong Mao (who invented the workaround) and Chaotian Jing, to see if they can advise us how to proceed. In any case, I think we should add a stable tag and a fixes tag. Kind regards Uffe > --- > drivers/mmc/host/mtk-sd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index a704745e5882..3dc102eefe49 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -524,7 +524,7 @@ static const struct mtk_mmc_compatible mt7622_compat = { > > static const struct mtk_mmc_compatible mt8516_compat = { > .clk_div_bits = 12, > - .recheck_sdio_irq = false, > + .recheck_sdio_irq = true, > .hs400_tune = false, > .pad_tune_reg = MSDC_PAD_TUNE0, > .async_fifo = true, > -- > 2.28.0 >