From: Dan Carpenter <dan.carpen...@oracle.com>

[ Upstream commit 8ce24f8967df2836b4557a23e74dc4bb098249f1 ]

This code should clean up if sm501_init_dev() fails.

Fixes: b6d6454fdb66 ("[PATCH] mfd: SM501 core driver")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Lee Jones <lee.jo...@linaro.org>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/mfd/sm501.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
index 3270b8dbc9498..4ca245518a199 100644
--- a/drivers/mfd/sm501.c
+++ b/drivers/mfd/sm501.c
@@ -1425,8 +1425,14 @@ static int sm501_plat_probe(struct platform_device *dev)
                goto err_claim;
        }
 
-       return sm501_init_dev(sm);
+       ret = sm501_init_dev(sm);
+       if (ret)
+               goto err_unmap;
+
+       return 0;
 
+ err_unmap:
+       iounmap(sm->regs);
  err_claim:
        release_resource(sm->regs_claim);
        kfree(sm->regs_claim);
-- 
2.25.1



Reply via email to