From: Ilya Leoshkevich <i...@linux.ibm.com>

[ Upstream commit fec47bbc10b243690f5d0ee484a0bbdee273e71b ]

getsetsockopt() calls getsockopt() with optlen == 1, but then checks
the resulting int. It is ok on little endian, but not on big endian.

Fix by checking char instead.

Fixes: 8a027dc0d8f5 ("selftests/bpf: add sockopt test that exercises sk 
helpers")
Signed-off-by: Ilya Leoshkevich <i...@linux.ibm.com>
Signed-off-by: Daniel Borkmann <dan...@iogearbox.net>
Acked-by: Andrii Nakryiko <andr...@fb.com>
Link: https://lore.kernel.org/bpf/20200915113928.3768496-1-...@linux.ibm.com
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 tools/testing/selftests/bpf/prog_tests/sockopt_sk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt_sk.c 
b/tools/testing/selftests/bpf/prog_tests/sockopt_sk.c
index 5f54c6aec7f07..b25c9c45c1484 100644
--- a/tools/testing/selftests/bpf/prog_tests/sockopt_sk.c
+++ b/tools/testing/selftests/bpf/prog_tests/sockopt_sk.c
@@ -45,9 +45,9 @@ static int getsetsockopt(void)
                goto err;
        }
 
-       if (*(int *)big_buf != 0x08) {
+       if (*big_buf != 0x08) {
                log_err("Unexpected getsockopt(IP_TOS) optval 0x%x != 0x08",
-                       *(int *)big_buf);
+                       (int)*big_buf);
                goto err;
        }
 
-- 
2.25.1



Reply via email to