From: YueHaibing <yuehaib...@huawei.com>

[ Upstream commit d04afe14b23651e7a8bc89727a759e982a8458e4 ]

In stmfts_sysfs_hover_enable_write(), we should check value and
sdata->hover_enabled is all true.

Fixes: 78bcac7b2ae1 ("Input: add support for the STMicroelectronics FingerTip 
touchscreen")
Signed-off-by: YueHaibing <yuehaib...@huawei.com>
Link: https://lore.kernel.org/r/20200916141941.16684-1-yuehaib...@huawei.com
Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/input/touchscreen/stmfts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/stmfts.c 
b/drivers/input/touchscreen/stmfts.c
index b6f95f20f9244..cd8805d71d977 100644
--- a/drivers/input/touchscreen/stmfts.c
+++ b/drivers/input/touchscreen/stmfts.c
@@ -479,7 +479,7 @@ static ssize_t stmfts_sysfs_hover_enable_write(struct 
device *dev,
 
        mutex_lock(&sdata->mutex);
 
-       if (value & sdata->hover_enabled)
+       if (value && sdata->hover_enabled)
                goto out;
 
        if (sdata->running)
-- 
2.25.1



Reply via email to