On Wed, Oct 28, 2020 at 04:51:19PM +0100, Arnd Bergmann wrote: > (resending from the kernel.org address because of bounces) > > On Tue, Oct 27, 2020 at 11:07 PM Arnd Bergmann <[email protected]> wrote: > > > > On Tue, Oct 27, 2020 at 6:58 PM Andy Shevchenko > > <[email protected]> wrote: > > > > > static int pvpanic_mmio_probe(struct platform_device *pdev) > > > { > > > - base = devm_platform_ioremap_resource(pdev, 0); > > > + struct device *dev = &pdev->dev; > > > + struct resource *res; > > > + > > > + res = platform_get_mem_or_io_resource(pdev, 0); > > > + if (res && resource_type(res) == IORESOURCE_IO) > > > + base = devm_ioport_map(dev, res->start, > > > resource_size(res)); > > > + else > > > + base = devm_ioremap_resource(dev, res); > > > > Maybe this could already be combined into a devm_platform_iomap_resource() > > similar to pci_iomap()?
Why not as a next iteration, because I don't see right now many users of this. -- With Best Regards, Andy Shevchenko
