Hi Heikki, Thank you for reviewing the patch!
On Wed, Oct 28, 2020 at 03:17:32PM +0200, Heikki Krogerus wrote: > Hi, > > On Wed, Oct 21, 2020 at 01:53:16PM -0700, Prashant Malani wrote: > > +static void cros_typec_unregister_altmodes(struct cros_typec_data *typec, > > int port_num) > > +{ > > + struct cros_typec_port *port = typec->ports[port_num]; > > + struct cros_typec_altmode_node *node; > > + > > + while (!list_empty(&port->partner_mode_list)) { > > + node = list_first_entry(&port->partner_mode_list, struct > > cros_typec_altmode_node, > > + list); > > ... > struct cros_typec_altmode_node *node, *tmp; > > list_for_each_entry_safe(node, tmp, &port->partner_mode_list, list) { > Nice; I will make this update in v2. Thanks! Best regards, -Prashant