Michal Hocko <[email protected]> writes: > On Wed 28-10-20 10:34:10, Huang Ying wrote: >> To follow code-of-conduct better. > > This is changing a user visible interface and any userspace which refers > to the existing name will fail to compile unless I am missing something.
Although these flags are put in uapi, I found these flags are actually internal flags used in "flags" field of struct mempolicy, they are never used as flags for any user space API. I guess they are placed in uapi header file to guarantee they aren't conflict with MPOL_MODE_FLAGS. > Have you checked how many applications would be affected? Based on above analysis, I think there is no application that will be affected. > Btw I find "follow CoC better" a very weak argument without further > explanation. That is the only reason for the patch. If nobody thinks the change is necessary, I can just drop the patch. Best Regards, Huang, Ying >> Signed-off-by: "Huang, Ying" <[email protected]> >> Suggested-by: "Matthew Wilcox (Oracle)" <[email protected]> >> Acked-by: Rafael Aquini <[email protected]> >> Cc: Andrew Morton <[email protected]> >> Cc: Ingo Molnar <[email protected]> >> Cc: Mel Gorman <[email protected]> >> Cc: Rik van Riel <[email protected]> >> Cc: Johannes Weiner <[email protected]> >> Cc: Dave Hansen <[email protected]> >> Cc: Andi Kleen <[email protected]> >> Cc: Michal Hocko <[email protected]> >> Cc: David Rientjes <[email protected]> >> Cc: Rafael Aquini <[email protected]> >> --- >> include/uapi/linux/mempolicy.h | 2 +- >> kernel/sched/debug.c | 2 +- >> mm/mempolicy.c | 6 +++--- >> 3 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/include/uapi/linux/mempolicy.h b/include/uapi/linux/mempolicy.h >> index 3354774af61e..3c3666d017e6 100644 >> --- a/include/uapi/linux/mempolicy.h >> +++ b/include/uapi/linux/mempolicy.h >> @@ -60,7 +60,7 @@ enum { >> #define MPOL_F_SHARED (1 << 0) /* identify shared policies */ >> #define MPOL_F_LOCAL (1 << 1) /* preferred local allocation */ >> #define MPOL_F_MOF (1 << 3) /* this policy wants migrate on fault */ >> -#define MPOL_F_MORON (1 << 4) /* Migrate On protnone Reference On >> Node */ >> +#define MPOL_F_MOPRON (1 << 4) /* Migrate On Protnone Reference On >> Node */ >> >> >> #endif /* _UAPI_LINUX_MEMPOLICY_H */ >> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c >> index 0655524700d2..8bfb6adb3f31 100644 >> --- a/kernel/sched/debug.c >> +++ b/kernel/sched/debug.c >> @@ -898,7 +898,7 @@ static void sched_show_numa(struct task_struct *p, >> struct seq_file *m) >> >> task_lock(p); >> pol = p->mempolicy; >> - if (pol && !(pol->flags & MPOL_F_MORON)) >> + if (pol && !(pol->flags & MPOL_F_MOPRON)) >> pol = NULL; >> mpol_get(pol); >> task_unlock(p); >> diff --git a/mm/mempolicy.c b/mm/mempolicy.c >> index 3fde772ef5ef..f6948b659643 100644 >> --- a/mm/mempolicy.c >> +++ b/mm/mempolicy.c >> @@ -2511,7 +2511,7 @@ int mpol_misplaced(struct page *page, struct >> vm_area_struct *vma, unsigned long >> } >> >> /* Migrate the page towards the node whose CPU is referencing it */ >> - if (pol->flags & MPOL_F_MORON) { >> + if (pol->flags & MPOL_F_MOPRON) { >> polnid = thisnid; >> >> if (!should_numa_migrate_memory(current, page, curnid, thiscpu)) >> @@ -2802,7 +2802,7 @@ void __init numa_policy_init(void) >> preferred_node_policy[nid] = (struct mempolicy) { >> .refcnt = ATOMIC_INIT(1), >> .mode = MPOL_PREFERRED, >> - .flags = MPOL_F_MOF | MPOL_F_MORON, >> + .flags = MPOL_F_MOF | MPOL_F_MOPRON, >> .v = { .preferred_node = nid, }, >> }; >> } >> @@ -3010,7 +3010,7 @@ void mpol_to_str(char *buffer, int maxlen, struct >> mempolicy *pol) >> unsigned short mode = MPOL_DEFAULT; >> unsigned short flags = 0; >> >> - if (pol && pol != &default_policy && !(pol->flags & MPOL_F_MORON)) { >> + if (pol && pol != &default_policy && !(pol->flags & MPOL_F_MOPRON)) { >> mode = pol->mode; >> flags = pol->flags; >> } >> -- >> 2.28.0 >>
