From: Julia Lawall <[EMAIL PROTECTED]> There should be an of_node_put when breaking out of a loop that iterates using for_each_node_by_type.
This was detected and fixed using the following semantic patch. (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ identifier d; type T; expression e; iterator for_each_node_by_type; @@ T *d; ... for_each_node_by_type(d,...) {... when != of_node_put(d) when != e = d ( return d; | + of_node_put(d); ? return ...; ) ...} // </smpl> Signed-off-by: Julia Lawall <[EMAIL PROTECTED]> --- diff -u -p a/arch/sparc/kernel/devices.c b/arch/sparc/kernel/devices.c --- a/arch/sparc/kernel/devices.c 2006-11-30 19:04:17.000000000 +0100 +++ b/arch/sparc/kernel/devices.c 2007-12-02 17:57:39.000000000 +0100 @@ -62,8 +62,10 @@ static int __cpu_find_by(int (*compare)( int err = check_cpu_node(dp->node, &cur_inst, compare, compare_arg, prom_node, mid); - if (!err) + if (!err) { + of_node_put(dp); return 0; + } } return -ENODEV; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
